Skip to content

docs: fix incorrect bash allow-list comment in README#712

Merged
jamesadevine merged 2 commits into
mainfrom
copilot/fix-docs-bash-allow-list-comment
May 23, 2026
Merged

docs: fix incorrect bash allow-list comment in README#712
jamesadevine merged 2 commits into
mainfrom
copilot/fix-docs-bash-allow-list-comment

Conversation

Copilot AI commented May 23, 2026

Copy link
Copy Markdown
Contributor

The bash: comment in the README's MCP Servers → Built-in Tools tools: example misrepresented both omission and [] as yielding a "safe-command default" — a concept that doesn't exist. In reality, omitting bash: gives unrestricted access and bash: [] disables bash entirely.

Summary

Corrected the comment to match actual behavior (consistent with docs/tools.md and src/engine.rs):

  # Bash command allow-list. Omit or use [":*"] for unrestricted access;
  # set to [] to disable bash entirely. See docs/tools.md.

Test plan

Documentation-only change; no code paths affected.

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/ba1155ce-2698-4279-babe-2c514c5d497b

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect bash allow-list comment in README docs: fix incorrect bash allow-list comment in README May 23, 2026
Copilot AI requested a review from jamesadevine May 23, 2026 06:47
@jamesadevine jamesadevine marked this pull request as ready for review May 23, 2026 07:03
@jamesadevine jamesadevine merged commit 68f3fd6 into main May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: fix documentation drift — incorrect bash allow-list comment in README

2 participants